Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Resolution: Implement Events Section & Quality Changes #14

Merged
merged 19 commits into from
Oct 18, 2024

Conversation

Saransh-Jainbu
Copy link
Collaborator

Issue Number closed Events Section #5 :

Important Checklist:

  • [✔️ ] You have prettyfied your code (npx prettier --write .)
  • [✔️] Linted the code using ESLint (npx eslint . --ext .js,.jsx,.ts,.tsx)
  • [✔️ ] This code is best you could write in terms of quality (we don't mind even if its bad :P)
  • [✔️ ] You have attached the screenshot of visible chnages in GUI, if any
  • [✔️ ] You have no merge conflicts, you have pulled and rebased your PR branch
  • [✔️ ] All CI tests have passed

src/app/globals.css Outdated Show resolved Hide resolved
public/data/events.json Show resolved Hide resolved
src/app/page.js Outdated Show resolved Hide resolved
src/app/globals.css Outdated Show resolved Hide resolved
@g4ze
Copy link
Member

g4ze commented Oct 15, 2024

[✔️ ] You have attached the screenshot of visible chnages in GUI, if any

unattended

@Saransh-Jainbu
Copy link
Collaborator Author

please refer the issue comment for image changes

@g4ze
Copy link
Member

g4ze commented Oct 15, 2024

Kindly attach an image here as well pls

@Saransh-Jainbu
Copy link
Collaborator Author

Issue: #5

Events Section Update:

Laptop View:

  • Screenshots for the updated layout on laptops:
    Laptop View 1
    Laptop View 2

Mobile View:

  • Mobile layout improvements:
    Mobile View

Name and Logo Update:

  • New logo and name:
    Logo Update

@g4ze g4ze merged commit 3b0d0f0 into GDG-OnCampus-BU:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants