Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor issues in the Dashboard #1611

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

TusharGupta03
Copy link

@TusharGupta03 TusharGupta03 commented Jun 19, 2024

Issue that this pull request solves

Closes: # (issue number)

Proposed changes

  1. Modules check updated from static to dynamic (From Database)
  2. Pop up on Invalid Credentials.
  3. Fusion icon in title bar tab of browser.
  4. While switching profile a warning will be displayed first.
  5. If the user is operating inside a module and switches profile in between , then it will be redirected to dashboard.
  6. Background Image in the Home and login Page.

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@TusharGupta03
Copy link
Author

@hrithik-09

@ChaudharyRaman
Copy link
Contributor

@prabhatsuman PTAL!! Otherwise LGTM !!

@prabhatsuman
Copy link

@ChaudharyRaman LGTM

@ChaudharyRaman ChaudharyRaman merged commit 92cc502 into FusionIIIT:latest_staging Jul 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants