-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a post creation form #31
base: mock-ui
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More general thing: capitalize first letters of the placeholders.
EDIT: also, change the URL to make it uniform with mock-ui (#8) branch.
pages/add-post.vue
Outdated
small-chips | ||
multiple | ||
label="zdjęcia" | ||
max="2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem that there is a limit for the images added.
pages/add-post.vue
Outdated
<v-btn class="ml-8 mt-5" style="color: #eee; background: #5570d5"> | ||
dodaj | ||
</v-btn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of now, this button does nothing.
pages/add-post.vue
Outdated
<v-file-input | ||
v-model="files" | ||
small-chips | ||
multiple | ||
label="zdjęcia" | ||
max="2" | ||
></v-file-input> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add multiple files only in the same dialogue: clicking the field again makes the files reset. You should also be able to discard the files separately, and not necessarily only as a whole. I assume this would most likely require us to build a more advanced mechanism for file input. That field also could use some kind of a preview, too.
pages/add-post.vue
Outdated
small-chips | ||
multiple | ||
label="zdjęcia" | ||
max="2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's a limit on the amount of files sent, it seems to not work. Also, 2 images seem like a pretty low number. That's something to discuss, but I guess 5 (or even 10?) would be better?
Reasoning in the respective PR, TL;DR: we need to actually cooperate with fundraising sites.
No description provided.