Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a post creation form #31

Open
wants to merge 14 commits into
base: mock-ui
Choose a base branch
from
Open

feat: add a post creation form #31

wants to merge 14 commits into from

Conversation

mwawrzen
Copy link

@mwawrzen mwawrzen commented Mar 3, 2021

No description provided.

@mwawrzen mwawrzen changed the title post-add-form feat: post-add-form Mar 3, 2021
@mwawrzen mwawrzen requested a review from Wuzado March 3, 2021 19:47
@Wuzado Wuzado changed the base branch from main to mock-ui March 3, 2021 19:51
@Wuzado Wuzado changed the title feat: post-add-form feat: add a post creation form Mar 7, 2021
Copy link
Contributor

@Wuzado Wuzado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More general thing: capitalize first letters of the placeholders.

EDIT: also, change the URL to make it uniform with mock-ui (#8) branch.

pages/add-post.vue Outdated Show resolved Hide resolved
small-chips
multiple
label="zdjęcia"
max="2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem that there is a limit for the images added.

Comment on lines 68 to 70
<v-btn class="ml-8 mt-5" style="color: #eee; background: #5570d5">
dodaj
</v-btn>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now, this button does nothing.

pages/add-post.vue Outdated Show resolved Hide resolved
pages/add-post.vue Outdated Show resolved Hide resolved
Comment on lines 61 to 67
<v-file-input
v-model="files"
small-chips
multiple
label="zdjęcia"
max="2"
></v-file-input>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add multiple files only in the same dialogue: clicking the field again makes the files reset. You should also be able to discard the files separately, and not necessarily only as a whole. I assume this would most likely require us to build a more advanced mechanism for file input. That field also could use some kind of a preview, too.

pages/add-post.vue Outdated Show resolved Hide resolved
pages/add-post.vue Outdated Show resolved Hide resolved
pages/add-post.vue Outdated Show resolved Hide resolved
small-chips
multiple
label="zdjęcia"
max="2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's a limit on the amount of files sent, it seems to not work. Also, 2 images seem like a pretty low number. That's something to discuss, but I guess 5 (or even 10?) would be better?

@Wuzado Wuzado mentioned this pull request Mar 11, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants