fade_in_out error when steam = True #524
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Efficient tensor handling: You're using .cpu() and .to(device) to move tensors between devices (CPU/GPU), which is fine for this operation.
Ensure that this moving between devices doesn't introduce unnecessary overhead if used within large loops.
Clone operation: The clone() method is a good choice here to avoid in-place modifications to the input fade_in_mel.
Window length check: Ensure that the window’s length matches or exceeds the required overlap length.