Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement predicates/scripts CLI deploy #3254

Merged
merged 5 commits into from
Oct 5, 2024
Merged

feat: implement predicates/scripts CLI deploy #3254

merged 5 commits into from
Oct 5, 2024

Conversation

Dhaiwat10
Copy link
Member

Release notes

In this release, we:

  • Did this and that

Summary

Breaking Changes

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Oct 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 10:41am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 10:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ts-api-docs ⬜️ Ignored (Inspect) Oct 5, 2024 10:41am

@Dhaiwat10 Dhaiwat10 changed the base branch from master to aa/feat/deploying-scripts-and-predicates October 5, 2024 09:21
@github-actions github-actions bot added the feat Issue is a feature label Oct 5, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Oct 5, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3254 will not alter performance

Comparing dp/scripts-predicates-cli (55de8df) with aa/feat/deploying-scripts-and-predicates (42d3480)

Summary

✅ 18 untouched benchmarks

nedsalk
nedsalk approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, we'll have to refactor out the deploying of the loader bytecode via the ContractFactory, but we can do that later.

@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review October 5, 2024 11:06
@Dhaiwat10 Dhaiwat10 merged commit ce44041 into aa/feat/deploying-scripts-and-predicates Oct 5, 2024
16 of 22 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/scripts-predicates-cli branch October 5, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dhaiwat10 @petertonysmith94 @nedsalk