Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable no-continue eslint rule #3225

Merged
merged 7 commits into from
Oct 1, 2024
Merged

chore: disable no-continue eslint rule #3225

merged 7 commits into from
Oct 1, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Sep 27, 2024 •
edited
Loading

Summary

Disabled no-continue rule and removed its usages after majority agreed it's okay to use it.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the chore Issue is a chore label Sep 27, 2024
@nedsalk nedsalk self-assigned this Sep 27, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:48am
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:48am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Oct 1, 2024 11:48am

@nedsalk nedsalk enabled auto-merge (squash) September 27, 2024 13:39
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.67%(+0%) 71.45%(-0.03%) 75.65%(+0%) 76.76%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 76.71%
(-1.37%)		 84%
(+0%)		 88.81%
(+0%)

maschad
maschad previously approved these changes Sep 27, 2024
View reviewed changes
danielbate
danielbate previously approved these changes Sep 30, 2024
View reviewed changes
.changeset/thin-waves-care.md Show resolved Hide resolved
@nedsalk nedsalk changed the base branch from master to next September 30, 2024 13:15
@nedsalk nedsalk dismissed stale reviews from danielbate and maschad September 30, 2024 13:15

The base branch was changed.

@nedsalk nedsalk enabled auto-merge (squash) September 30, 2024 14:15
@nedsalk nedsalk merged commit 115a1f1 into next Oct 1, 2024
24 checks passed
@nedsalk nedsalk deleted the ns/chore/disable-no-continue branch October 1, 2024 12:00
maschad pushed a commit that referenced this pull request Oct 1, 2024
@nedsalk @maschad
chore: disable no-continue eslint rule (#3225)
b43cf2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

Assignees

@nedsalk nedsalk

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nedsalk @arboleya @danielbate @maschad @petertonysmith94