This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
enhancement: forc index status: report indexer status and errors #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostman
force-pushed
the
maciej/1316-forc-index-status-report-errors
branch
from
October 16, 2023 16:15
decaa21
to
399f258
Compare
lostman
changed the title
enhancement: forc index status
enhancement: forc index status: report indexer status and errors
Oct 16, 2023
lostman
force-pushed
the
maciej/1316-forc-index-status-report-errors
branch
from
October 16, 2023 22:46
7a8c7a0
to
5c5daee
Compare
lostman
force-pushed
the
maciej/1316-forc-index-status-report-errors
branch
from
October 17, 2023 11:48
da95581
to
6a52757
Compare
deekerno
previously approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent. Thanks @lostman!
ra0x3
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This mostly looks OK
- However, I'm personally not sure how this works
- Does this work for a single indexer? For a single public key? This works for all indexers under a given public key? What if I want to check the status of a single indexer?
- If these have simple answers, I don't think we need docs
- If these answers are a bit more invovled, maybe we'll have to add a
## Usage
section indocs > src > forc-index > status.md
packages/fuel-indexer-database/postgres/migrations/20231012190730_indexer_status.up.sql
Outdated
Show resolved
Hide resolved
ra0x3
suggested changes
Oct 18, 2023
packages/fuel-indexer-database/postgres/migrations/20231012190730_indexer_status.up.sql
Outdated
Show resolved
Hide resolved
lostman
force-pushed
the
maciej/1316-forc-index-status-report-errors
branch
from
October 18, 2023 18:12
ab26d1b
to
e537288
Compare
lostman
force-pushed
the
maciej/1316-forc-index-status-report-errors
branch
from
October 18, 2023 18:36
e537288
to
0498316
Compare
ra0x3
previously approved these changes
Oct 18, 2023
deekerno
previously approved these changes
Oct 18, 2023
ra0x3
approved these changes
Oct 18, 2023
deekerno
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1316.
This PR adds information about active indexers to
forc index status
.Testing steps
Start Fuel Indexer Service:
Modify
fuel-explorer
to trigger a panic:Deploy:
Deploy another indexer:
Check the status
fuel-explorer
's status should be anerror
while the other indexer's status should berunning
, and the status message should show an increasing block count.Changelog
forc index status
IndexerStatus
andIndexerStatusKind
typesindex_status
table to hold the new informationhumantime
formatting ofcreated at
, e.g.(23 min 30s ago)