-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
c02203f
to
8d711d0
Compare
bb9b3cb
to
025ad3a
Compare
# ******************************** | ||
|
||
# TODO: https://github.com/FuelLabs/fuel-indexer/issues/1069 | ||
# cd ../greetings-native |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There's something odd happening on CI here where starting this indexer sort've blocks the rest of CI - even if the command is launched in the background.
- I want to continue to look into this but don't want to block the PR
- However, you can confirm that running these steps locally works
@ra0x3 I'm reviewing this now; while I'm doing that, can you share the reasoning behind adding a separate command -- |
Oops, you're totally right. And in that case, I think "run-native" is fine. I'm just thinking that we can keep it as a separate operation but maybe invoke it as |
|
cee07c2
to
60cc87f
Compare
@@ -1,6 +1,10 @@ | |||
use duct::cmd; | |||
use fuel_indexer_lib::config::IndexerConfig; | |||
|
|||
const FUEL_INDEXER: &str = "./../../target/release/fuel-indexer"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could run all of these through cargo run --bin PKG
to make this fully automatic. These are better than before—no need to manipulate the path—but still require pre-building the binaries before running tests.
Thanks for opening a PR with the Fuel Indexer project. Please review the Checklist below and ensure you've completed all of the necessary steps to make this PR review as painless as possible.
Checklist
Description
forc index new
and called it "hello world" (since this is our actual hello world example)greetings-native
example (all examples are now dockerized)forc index run-native
command to run native indexersTesting steps
Ensure new command works
Ensure examples work
Hello world
Greetings
Greetings Native
Changelog