Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

chore: add sway app abi tests #1341

Merged
merged 2 commits into from
Sep 29, 2023
Merged

chore: add sway app abi tests #1341

merged 2 commits into from
Sep 29, 2023

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Sep 11, 2023 •
edited
Loading

Thanks for opening a PR with the Fuel Indexer project. Please review the Checklist below and ensure you've completed all of the necessary steps to make this PR review as painless as possible.

Checklist

  • Ensure your top-level commit message is in line with our contributor guidelines.
  • Please add proper labels.
  • If there is an issue associated with this PR, please link the issue (right-hand sidebar)
  • If there is not an issue associated with this PR, add this PR to the "Fuel Indexer" project (right-hand sidebar)
  • Please allow Codeowners at least 24 hours to do a first-pass review.
  • Please add thoroughly detailed testing steps below.
  • Please keep your Changelog message short and sweet.

Description

  • Adds a ton of trybuild tests from actual real Sway apps
  • Fixes small bugs found in the process related to missing types
  • I've created issues to investigate all types added to IGNORED_METADATA_TYPES

Usage

To copy over the latest Sway app ABI JSON

bash packages/fuel-indexer-tests/scripts/copy-swap-app-abi.bash /path/to/sway-applications

Testing steps

  • CI should pass

Changelog

  • chore: add sway app abi tests

@ra0x3 ra0x3 self-assigned this Sep 11, 2023
@ra0x3 ra0x3 marked this pull request as draft September 11, 2023 14:44
Base automatically changed from rashad/1322-vec-support to develop September 11, 2023 18:16
@ra0x3 ra0x3 force-pushed the rashad/add-sway-app-abi-tests branch 2 times, most recently from 95028c5 to a8fd1e4 Compare September 25, 2023 15:49
This was referenced Sep 27, 2023
Open
Open
Closed
ra0x3
ra0x3 commented Sep 27, 2023
View reviewed changes
packages/fuel-indexer-tests/tests/trybuild.rs
TestKind::Pass,
manifest_with_contract_abi("exchange-contract-abi.json"),
),
// NOTE: I don't think the ABI tokens are being properly generated from this contract JSON
Copy link
Contributor Author

@ra0x3 ra0x3 Sep 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will ask the Sway team and the SDK team why this particular contract presents an issue. There is a simple struct EvmAddress that for whatever reason is just not returned in the ABI tokens (so on the SDK side)

@ra0x3 ra0x3 marked this pull request as ready for review September 27, 2023 21:59
@ra0x3 ra0x3 force-pushed the rashad/add-sway-app-abi-tests branch 2 times, most recently from 48cf166 to f82538b Compare September 27, 2023 22:42
@ra0x3 ra0x3 force-pushed the rashad/add-sway-app-abi-tests branch from f82538b to 990a103 Compare September 27, 2023 22:49
@ra0x3 ra0x3 added the bug Something isn't working label Sep 27, 2023
@ra0x3 ra0x3 linked an issue Sep 28, 2023 that may be closed by this pull request
Try using Sway example app ABI as a part of CI #1336
Closed
@ra0x3 ra0x3 merged commit 7eea71f into develop Sep 29, 2023
18 checks passed
@ra0x3 ra0x3 deleted the rashad/add-sway-app-abi-tests branch September 29, 2023 15:43
@ra0x3 ra0x3 mentioned this pull request Oct 18, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deekerno deekerno deekerno approved these changes

@lostman lostman lostman approved these changes

Assignees

@ra0x3 ra0x3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try using Sway example app ABI as a part of CI
3 participants
@ra0x3 @lostman @deekerno