This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Made manifest contract_id work with both namespaced and non-namespaced contract IDs #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra0x3
suggested changes
Sep 5, 2023
There was a problem hiding this comment.
- Looks mostly ok, left some minor feedback
- If you want to add a blurb to the docs, you can open
manifest.md, go to thecontract_idsection, an add the following as a quote/blurb:
Note that this parameter supports both Bech32 contract IDs and non-Bech32 contract IDs
examples/fuel-explorer/fuel-explorer/fuel_explorer.manifest.yaml
Outdated
Show resolved
Hide resolved
examples/hello-world-native/hello-indexer-native/hello_indexer_native.manifest.yaml
Outdated
Show resolved
Hide resolved
packages/fuel-indexer-tests/indexers/fuel-indexer-test/fuel_indexer_test.yaml
Outdated
Show resolved
Hide resolved
|
deekerno
approved these changes
Sep 11, 2023
dadepo
deleted the
1137/contract_id-work-with-namespace-and-non-namespace
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1137
Description
Made manifest contract_id work with both namespaced and non-namespaced contract IDs
Changelog
Updated the logic that parses the address in the manifest to Bech32ContractId to work with both namespace and non-space addresses.