Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow DA recorded blocks to come out-of-order #2415
Allow DA recorded blocks to come out-of-order #2415
Changes from 1 commit
448d8c2
c5866a3
c54f098
fcf4477
159d5b4
ba080ff
d2b3c28
128a9ba
5f19932
922f3e0
d7e9bdd
12c517e
f8dca06
2bb86fe
60771e9
03da963
ea14e6f
b615b33
cfd1a71
d983891
4c2b844
48fe978
b578a8e
7ca55c7
6ac41de
f2af4aa
cc90cbd
7ac01aa
9f78fa6
a2c0125
57ed9db
eff76bf
4d5409a
4e8df28
757896a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about the following scenario, not sure if this is an issue or not:
self.unrecorded_blocks
remove()
2 of them, but we get an error on 3rd oneunrecorded_blocks_bytes
becomes out-of-syncThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This is the inverse of the problem I mentioned above.