Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2344 add support for multi get operation in the database #2396

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Oct 25, 2024

Draft PR for early feedback. I'm a bit torn regarding the boxed iterators. While they are a bit more ergonomic and flexible as opposed to working directly with slices/vecs, it's also very verbose and I'm also worried about all the levels of boxing hurting performance.

EDIT: Rewritten to not modify the StorageInspect trait after feedback in Slack.
Note that the VM changes aren't visible in this PR. I will open a separate PR for them, but for reference this is how the StorageInspect trait is assumed to be extended in the current version:

Linked Issues/PRs

Closes #2344

Description

This PR extends the KeyValueInspect trait using Boxed iterators.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@netrome netrome linked an issue Oct 25, 2024 that may be closed by this pull request
@netrome netrome changed the base branch from release/v0.40.0 to master October 25, 2024 09:12
@netrome netrome force-pushed the 2344-add-support-for-multi-get-operation-in-the-database branch from f9e0289 to 2532b06 Compare October 25, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multi-get operation in the Database
1 participant