2344 add support for multi get operation in the database #2396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for early feedback. I'm a bit torn regarding the boxed iterators. While they are a bit more ergonomic and flexible as opposed to working directly with slices/vecs, it's also very verbose and I'm also worried about all the levels of boxing hurting performance.
EDIT: Rewritten to not modify the
StorageInspect
trait after feedback in Slack.Note that the VM changes aren't visible in this PR. I will open a separate PR for them, but for reference this is how theStorageInspect
trait is assumed to be extended in the current version:Linked Issues/PRs
Closes #2344
Description
This PR extends the
KeyValueInspect
trait using Boxed iterators.Checklist
Before requesting review