Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flag depth in TxPool #2387

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

AurelienFT
Copy link
Contributor

Linked Issues/PRs

Resolves #2313

Description

This PR renames a flag that hasn't been updated with new tx pool to avoid breaking change but that flag name isn't approriate anymore.
@xgreenx whenever you are confortable with pushing this breaking change ping here and I will update the CHANGELOG and change the PR to ready for review.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@AurelienFT AurelienFT self-assigned this Oct 24, 2024
@AurelienFT AurelienFT added the breaking A breaking api change label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking api change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant