-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for permit based tokens in erc20 gateway #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
viraj124
commented
Oct 8, 2024
•
edited
Loading
edited
- closes Support Permit and/or Permit2 to ERC20 bridge #156
- implements EIP 2612 in the gateway
This PR is published in NPM with version **** |
viraj124
changed the title
add permit token support for erc20 gateway
feat: add permit token support for erc20 gateway
Oct 9, 2024
viraj124
changed the title
feat: add permit token support for erc20 gateway
feat: add support to handle approvals for token with permit feature in erc20 gateway
Oct 9, 2024
viraj124
changed the title
feat: add support to handle approvals for token with permit feature in erc20 gateway
feat: add support for permit based tokens in erc20 gateway
Oct 9, 2024
PraneshASP
requested changes
Oct 9, 2024
packages/solidity-contracts/contracts/messaging/gateway/FuelERC20Gateway/FuelERC20GatewayV4.sol
Outdated
Show resolved
Hide resolved
packages/solidity-contracts/contracts/messaging/gateway/FuelERC20Gateway/FuelERC20GatewayV4.sol
Outdated
Show resolved
Hide resolved
PraneshASP
reviewed
Oct 9, 2024
PraneshASP
previously approved these changes
Oct 9, 2024
PraneshASP
reviewed
Oct 10, 2024
packages/solidity-contracts/test/behaviors/erc20GatewayV4.behavior.test.ts
Outdated
Show resolved
Hide resolved
DefiCake
approved these changes
Oct 21, 2024
PraneshASP
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.