fix: TS Linting in test packages (#351)

- add ts linting for all test packages

.changeset/small-singers-attend.md

@@ -0,0 +1,6 @@
+---
+'@fuel-bridge/solidity-contracts': minor
+'@fuel-bridge/test-utils': minor
+---
+
+ts linting for test packages

.eslintignore

@@ -4,3 +4,4 @@
 **/typechain/
 docker/l1-chain/hardhat
 dist
+**/exports/

packages/integration-tests/tests/bridge_erc20.ts

@@ -642,7 +642,7 @@ describe('Bridging ERC20 tokens', async function () {
 
     it('Rate limit parameters are updated when current withdrawn amount is more than the new limit & set a new higher limit', async () => {
       const deployer = await env.eth.deployer;
-      let newRateLimit = '5';
+      const newRateLimit = '5';
 
       let withdrawnAmountBeforeReset =
         await env.eth.fuelERC20Gateway.currentPeriodAmount(

packages/integration-tests/tests/bridge_mainnet_tokens.ts

@@ -2,19 +2,19 @@ import type { BridgeFungibleToken } from '@fuel-bridge/fungible-token';
 import {
   RATE_LIMIT_AMOUNT,
   RATE_LIMIT_DURATION,
+  USDT_ADDRESS,
+  USDC_ADDRESS,
+  WBTC_ADDRESS,
+  WETH_ADDRESS,
 } from '@fuel-bridge/solidity-contracts/protocol/constants';
-import {
+import type {
   CustomToken,
   CustomTokenWETH,
+} from '@fuel-bridge/solidity-contracts/typechain';
+import {
   CustomToken__factory,
   CustomTokenWETH__factory,
 } from '@fuel-bridge/solidity-contracts/typechain';
-import {
-  USDT_ADDRESS,
-  USDC_ADDRESS,
-  WBTC_ADDRESS,
-  WETH_ADDRESS,
-} from '@fuel-bridge/solidity-contracts/protocol/constants';
 import type { TestEnvironment } from '@fuel-bridge/test-utils';
 import {
   setupEnvironment,
@@ -89,8 +89,7 @@ describe('Bridge mainnet tokens', function () {
       fuel_AssetId
     );
 
-    let transactionRequest;
-    transactionRequest = await fuel_bridge.functions
+    const transactionRequest = await fuel_bridge.functions
       .withdraw(paddedAddress)
       .addContracts([fuel_bridge, fuel_bridgeImpl])
       .txParams({
@@ -232,7 +231,6 @@ describe('Bridge mainnet tokens', function () {
         const NUM_TOKENS = 100000000000000000000n;
         let ethereumTokenSender: Signer;
         let ethereumTokenSenderAddress: string;
-        let ethereumTokenSenderBalance: bigint;
         let fuelTokenReceiver: FuelWallet;
         let fuelTokenReceiverAddress: string;
         let fuelTokenReceiverBalance: BN;
@@ -247,20 +245,12 @@ describe('Bridge mainnet tokens', function () {
             await weth_testToken
               .connect(ethereumTokenSender)
               .deposit({ value: NUM_TOKENS });
-
-            ethereumTokenSenderBalance = await weth_testToken.balanceOf(
-              ethereumTokenSenderAddress
-            );
           } else {
             const mintAmount =
               BigInt(NUM_TOKENS) / 10n ** (18n - decimals[index]);
             await customToken
               .mint(ethereumTokenSender, mintAmount)
               .then((tx) => tx.wait());
-
-            ethereumTokenSenderBalance = await customToken.balanceOf(
-              ethereumTokenSenderAddress
-            );
           }
 
           fuelTokenReceiver = env.fuel.signers[0];
@@ -302,10 +292,10 @@ describe('Bridge mainnet tokens', function () {
 
           fuelTokenMessageNonce = new BN(event.args.nonce.toString());
 
-          let newSenderBalance;
-
           // check that the sender balance has decreased by the expected amount
-          newSenderBalance = await token.balanceOf(ethereumTokenSenderAddress);
+          const newSenderBalance = await token.balanceOf(
+            ethereumTokenSenderAddress
+          );
 
           expect(newSenderBalance === 0n).to.be.true;
         });
@@ -315,15 +305,15 @@ describe('Bridge mainnet tokens', function () {
           this.timeout(FUEL_MESSAGE_TIMEOUT_MS);
 
           // relay the message ourselves
-          let message = await waitForMessage(
+          const message = await waitForMessage(
             env.fuel.provider,
             fuelTokenMessageReceiver,
             fuelTokenMessageNonce,
             FUEL_MESSAGE_TIMEOUT_MS
           );
           expect(message).to.not.be.null;
 
-          let tx = await relayCommonMessage(env.fuel.deployer, message, {
+          const tx = await relayCommonMessage(env.fuel.deployer, message, {
             gasLimit: 30000000,
             maturity: undefined,
             contractIds: [fuel_bridgeImpl.id.toHexString()],

packages/integration-tests/tests/bridge_proxy.ts

@@ -1,8 +1,8 @@
+import type { Proxy } from '@fuel-bridge/fungible-token';
 import type { TestEnvironment } from '@fuel-bridge/test-utils';
 import { setupEnvironment, getOrDeployL2Bridge } from '@fuel-bridge/test-utils';
 import chai from 'chai';
 import type { Contract, FuelError } from 'fuels';
-import { Proxy } from '@fuel-bridge/fungible-token';
 
 const { expect } = chai;
 

packages/integration-tests/tests/transfer_eth.ts

@@ -1,5 +1,5 @@
+import type { TestEnvironment } from '@fuel-bridge/test-utils';
 import {
-  TestEnvironment,
   setupEnvironment,
   fuels_parseEther,
   createRelayMessageParams,
@@ -14,9 +14,8 @@ import {
   hardhatSkipTime,
 } from '@fuel-bridge/test-utils';
 import chai from 'chai';
-import type { Signer } from 'ethers';
 import { parseEther } from 'ethers';
-import type { JsonRpcProvider } from 'ethers';
+import type { Signer, JsonRpcProvider } from 'ethers';
 import { Address, BN, padFirst12BytesOfEvmAddress } from 'fuels';
 import type {
   AbstractAddress,
@@ -264,6 +263,8 @@ describe('Transferring ETH', async function () {
       // withdraw ETH back to the base chain
       const blocksPerCommitInterval =
         await env.eth.fuelChainState.BLOCKS_PER_COMMIT_INTERVAL();
+
+      // eslint-disable-next-line no-constant-condition
       while (true) {
         const currentBlock = await env.fuel.provider.getBlockNumber();
         debug(`Current block ${currentBlock.toString()}`);
@@ -349,7 +350,7 @@ describe('Transferring ETH', async function () {
   });
 
   describe('ETH Withdrawls based on rate limit updates', async () => {
-    let NUM_ETH = '9';
+    const NUM_ETH = '9';
     const largeRateLimit = `30`;
     let fuelETHSender: FuelWallet;
     let ethereumETHReceiver: Signer;

packages/solidity-contracts/test/behaviors/erc20GatewayV4.behavior.test.ts

@@ -23,16 +23,16 @@ import {
 import { randomAddress, randomBytes32 } from '../../protocol/utils';
 import {
   CustomToken__factory,
-  NoDecimalsToken__factory
+  NoDecimalsToken__factory,
 } from '../../typechain';
 import type {
   MockFuelMessagePortal,
   FuelERC20GatewayV4,
   Token,
   CustomToken,
   NoDecimalsToken,
-
-  MockPermitToken} from '../../typechain';
+  MockPermitToken,
+} from '../../typechain';
 import { impersonateAccount } from '../utils/impersonateAccount';
 
 type Env = {

packages/test-utils/src/scripts/check-balances.ts

@@ -5,7 +5,8 @@
 import { password } from '@inquirer/prompts';
 import { Provider, WalletUnlocked } from 'fuels';
 
-let { L2_ADDRESS, L2_RPC } = process.env;
+let { L2_ADDRESS } = process.env;
+const { L2_RPC } = process.env;
 
 const main = async () => {
   const provider = await Provider.create(L2_RPC, { resourceCacheTTL: -1 });

packages/test-utils/src/scripts/check-nonce.ts

@@ -2,9 +2,10 @@
  * This is a stand-alone script that looks for a message nonce
  */
 
-import { BN, Message, Provider } from 'fuels';
+import type { Message } from 'fuels';
+import { BN, Provider } from 'fuels';
 
-let { L2_RPC, L2_MESSAGE_NONCE } = process.env;
+const { L2_RPC, L2_MESSAGE_NONCE } = process.env;
 
 const main = async () => {
   if (!L2_MESSAGE_NONCE) {

packages/test-utils/src/scripts/check-proxy-data.ts

@@ -4,11 +4,9 @@
  */
 
 import { Proxy } from '@fuel-bridge/fungible-token';
-
 import { Provider } from 'fuels';
 
-let { L2_RPC, L2_BRIDGE_ID } = process.env;
-const L1_LLAMA_RPC = 'https://eth.llamarpc.com';
+const { L2_RPC, L2_BRIDGE_ID } = process.env;
 const main = async () => {
   const fuel_provider = await Provider.create(L2_RPC, { resourceCacheTTL: -1 });
 

packages/test-utils/src/scripts/deploy-bridge.ts

@@ -8,17 +8,12 @@ import {
   BridgeFungibleTokenFactory,
   ProxyFactory,
 } from '@fuel-bridge/fungible-token';
-
-import {
-  DeployContractResult,
-  Provider,
-  Wallet,
-  WalletUnlocked,
-  ZeroBytes32,
-} from 'fuels';
 import { password } from '@inquirer/prompts';
+import type { DeployContractResult, WalletUnlocked } from 'fuels';
+import { Provider, Wallet, ZeroBytes32 } from 'fuels';
 
-let { L1_TOKEN_GATEWAY, L2_SIGNER, L2_RPC } = process.env;
+let { L2_SIGNER } = process.env;
+const { L1_TOKEN_GATEWAY, L2_RPC } = process.env;
 
 // This helper avoids an exception in the case that the contract
 // was already deployed, and returns the contract instead

packages/test-utils/src/scripts/deposit-to-coin.ts

@@ -3,10 +3,11 @@
  * to convert a message coin into a coin utxo
  */
 
-import { Provider, TransactionStatus, Wallet } from 'fuels';
 import { password } from '@inquirer/prompts';
+import { Provider, TransactionStatus, Wallet } from 'fuels';
 
-let { L2_SIGNER, L2_RPC } = process.env;
+let { L2_SIGNER } = process.env;
+const { L2_RPC } = process.env;
 
 const main = async () => {
   if (!L2_RPC) {

packages/test-utils/src/scripts/relay-deposit.ts

@@ -4,9 +4,8 @@
  */
 
 import { Proxy } from '@fuel-bridge/fungible-token';
-
 import { contractMessagePredicate } from '@fuel-bridge/message-predicates';
-
+import { password } from '@inquirer/prompts';
 import {
   Account,
   BN,
@@ -16,7 +15,7 @@ import {
   getPredicateRoot,
   hexlify,
 } from 'fuels';
-import { password } from '@inquirer/prompts';
+
 import {
   FUEL_MESSAGE_TIMEOUT_MS,
   debug,
@@ -26,7 +25,9 @@ import {
 
 const TOKEN_RECIPIENT_DATA_OFFSET = 160;
 
-let { L2_SIGNER, L2_RPC, L2_BRIDGE_ID, L2_MESSAGE_NONCE, L2_TOKEN_RECEIVER } =
+let { L2_SIGNER } = process.env;
+
+const { L2_RPC, L2_BRIDGE_ID, L2_MESSAGE_NONCE, L2_TOKEN_RECEIVER } =
   process.env;
 
 const main = async () => {
@@ -45,7 +46,7 @@ const main = async () => {
   console.log('\t> Balance: ', (await wallet.getBalance()).toString());
 
   debug('Detecting if the bridge is a proxy...');
-  let implementation_id: string | null = await proxy.functions
+  const implementation_id: string | null = await proxy.functions
     .proxy_target()
     .dryRun()
     .then((result) => {
@@ -63,7 +64,9 @@ const main = async () => {
   let endCursor: string | undefined;
 
   if (L2_MESSAGE_NONCE) nonce = new BN(L2_MESSAGE_NONCE);
+
   else
+    // eslint-disable-next-line no-constant-condition
     while (true) {
       const response = await provider.getMessages(predicateRoot, {
         after: endCursor,

packages/test-utils/src/scripts/relay-metadata.ts

@@ -4,9 +4,8 @@
  */
 
 import { Proxy } from '@fuel-bridge/fungible-token';
-
 import { contractMessagePredicate } from '@fuel-bridge/message-predicates';
-
+import { password } from '@inquirer/prompts';
 import {
   Account,
   BN,
@@ -15,15 +14,16 @@ import {
   Wallet,
   getPredicateRoot,
 } from 'fuels';
-import { password } from '@inquirer/prompts';
+
 import {
   FUEL_MESSAGE_TIMEOUT_MS,
   debug,
   relayCommonMessage,
   waitForMessage,
 } from '../utils';
 
-let { L2_SIGNER, L2_RPC, L2_BRIDGE_ID, L2_MESSAGE_NONCE } = process.env;
+let { L2_SIGNER } = process.env;
+const { L2_RPC, L2_BRIDGE_ID, L2_MESSAGE_NONCE } = process.env;
 
 const main = async () => {
   if (!L2_RPC) {
@@ -51,7 +51,7 @@ const main = async () => {
   console.log('\t> Balance: ', (await wallet.getBalance()).toString());
 
   debug('Detecting if the bridge is a proxy...');
-  let implementation_id: string | null = await proxy.functions
+  const implementation_id: string | null = await proxy.functions
     .proxy_target()
     .dryRun()
     .then((result) => {

packages/test-utils/src/scripts/transfer-bridge-ownership.ts

@@ -4,12 +4,13 @@
  */
 
 import { Proxy } from '@fuel-bridge/fungible-token';
-
-import { Provider, Wallet } from 'fuels';
 import { password } from '@inquirer/prompts';
+import { Provider, Wallet } from 'fuels';
+
 import { debug } from '../utils';
 
-let { L2_SIGNER, L2_RPC, L2_BRIDGE_ID, L2_NEW_OWNER } = process.env;
+let { L2_SIGNER } = process.env;
+const { L2_RPC, L2_BRIDGE_ID, L2_NEW_OWNER } = process.env;
 
 const main = async () => {
   const provider = await Provider.create(L2_RPC, { resourceCacheTTL: -1 });
@@ -27,7 +28,7 @@ const main = async () => {
   console.log('\t> Balance: ', (await wallet.getBalance()).toString());
 
   debug('Detecting if the bridge is a proxy...');
-  let owner: string | null = await proxy.functions
+  const owner: string | null = await proxy.functions
     ._proxy_owner()
     .dryRun()
     .then((result) => {