Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fuel-core 0.24.1 #62

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

segfault-magnet
Copy link
Contributor

Had to disable 2 integration tests checking whether we can communicate with fuel-core's API because fuels-rs hasn't had a release yet.

The same functionality is covered at a higher level with the e2e test so I'd say we're in the clear since the e2e test passes.

Once fuels-rs gets a release we can come back and uncomment the tests.

@segfault-magnet segfault-magnet added the enhancement New feature or request label Apr 2, 2024
@segfault-magnet segfault-magnet requested review from LuizAsFight and a team April 2, 2024 21:56
@segfault-magnet segfault-magnet self-assigned this Apr 2, 2024
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would just add an issue for the TODO

@segfault-magnet segfault-magnet merged commit 4b8d6b7 into master Apr 2, 2024
7 checks passed
@luizstacio
Copy link
Member

LGTM. I would just add an issue for the TODO

#63

@Voxelot
Copy link
Member

Voxelot commented Apr 3, 2024

we'll likely need to update again once the bridge catches up, since the header was changed to include some versioning fields

@segfault-magnet segfault-magnet deleted the feature/use_latest_core branch April 3, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants