chore: add tests for the state listener #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfault-magnet
requested review from
digorithm,
hal3e,
MujkicA,
Salka1988 and
Br1ght0ne
as code owners
hal3e
previously approved these changes
Oct 22, 2024
hal3e
approved these changes
Oct 28, 2024
MujkicA
reviewed
Oct 29, 2024
MujkicA
approved these changes
Oct 30, 2024
Comment on lines
+620
to
+624
| let replacement_tx = L1Tx { | ||
| hash: replacement_tx_hash, | ||
| created_at: Some(replacement_tx_time), | ||
| ..Default::default() | ||
| }; |
There was a problem hiding this comment.
being explicit here about replacements requiring the same nonce might save us some trouble later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some more tests that we didn't have time for in #138