Add support for js-ts-mode and typescript-ts-mode #1174
Conversation
| @@ -148,7 +148,7 @@ ID, ACTION, CONTEXT." | |||
| (eval-after-load 'tuareg '(require 'smartparens-ml)) | |||
| (eval-after-load 'fsharp-mode '(require 'smartparens-ml)) | |||
| (eval-after-load 'unisonlang-mode '(require 'smartparens-unison)) | |||
| (--each '(js js2-mode) | |||
| (--each '(js js2-mode typescript-ts-mode) | |||
There was a problem hiding this comment.
we should probably add js-ts-mode here as well then? Since you added it to the config.
There was a problem hiding this comment.
js-ts-mode is provided in js.el, so I believe just including js here should be sufficient for both js-mode and js-ts-mode (since I believe this form expects package names for eval-after-load, not mode symbols). typescript-ts-mode on the other hand is in its own package (typescript-ts-mode.el) and so needs its own entry here.
I believe the same applies for python. This line:
https://github.com/fuco1/smartparens/blob/96fccc0816093aaad4b904a20802ec306c6da420/smartparens-config.el#L135-L136
could probably just be:
(eval-after-load 'python '(require 'smartparens-python))
since both python-mode and python-ts-mode are defined in python.el.
|
Thanks! |
Adds the new Emacs 29+
js-ts-modeandtypescript/tsx-ts-modeto the configs forsmartparent-javascript.I also added
tsx-ts-modetosp--html-modeswhich should address #1168.