Improved error codes/messages consistency

Frontify · Oct 27, 2021 · 6280b96 · 6280b96
1 parent f3fe773
commit 6280b96
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/Logger.ts b/src/Logger.ts
@@ -21,7 +21,7 @@ export function logMessage(type: string, info: LogInfo): void {
  break;
  case 'error':
  if (!disabledLogs.errors) {
- console.error(`%c${info.code}:%c ${info.message}`, info.error || '');
+ console.error(`${info.code}: ${info.message}`, info.error || '');
  }
  break;
  default:

diff --git a/src/Oauth.ts b/src/Oauth.ts
@@ -74,7 +74,7 @@ export async function initializeOauthSession(domain: string): Promise<string> {
 
  return session?.data.key;
  } catch {
- throw new AuthenticatorError('ERR_SESSION', 'Error generating session.');
+ throw new AuthenticatorError('ERR_AUTH_SESSION', 'Error generating session.');
  }
 }
 

diff --git a/src/Popup.ts b/src/Popup.ts
@@ -88,7 +88,7 @@ export class Popup {
  );
 
  if (!popUp) {
- throw new AuthenticatorError('ERR_POPUP_BLOCKED', 'Popup is blocked. Make sure to enable popups.');
+ throw new AuthenticatorError('ERR_AUTH_POPUP_BLOCKED', 'Popup is blocked. Make sure to enable popups.');
  }
 
  return popUp;
@@ -139,6 +139,6 @@ export class Popup {
  return;
  }
 
- throw new AuthenticatorError('ERR_POPUP_CLOSED', 'Popup is closed.');
+ throw new AuthenticatorError('ERR_AUTH_POPUP_CLOSED', 'Popup is closed.');
  }
 }
diff --git a/src/Utils.ts b/src/Utils.ts
@@ -32,7 +32,7 @@ export async function httpCall<JsonResponse>(url: string, init?: RequestInit): P
  if (response.status >= 200 && response.status <= 299) {
  return (await response.json()) as JsonResponse;
  }
- throw new AuthenticatorError('ERR_HTTP_REQUEST', response.statusText);
+ throw new AuthenticatorError('ERR_AUTH_HTTP_REQUEST', response.statusText);
  })
  .then((response: JsonResponse): JsonResponse => {
  return response;
@@ -42,7 +42,7 @@ export async function httpCall<JsonResponse>(url: string, init?: RequestInit): P
  throw error;
  }
 
- throw new AuthenticatorError('ERR_HTTP_REQUEST', error);
+ throw new AuthenticatorError('ERR_AUTH_HTTP_REQUEST', error);
  });
 }
 

diff --git a/src/index.ts b/src/index.ts
@@ -58,7 +58,7 @@ export async function authorize(
  })
  .catch((error) => {
  if (error === false) {
- throw new AuthenticatorError('ERR_DOMAIN_POPUP_CLOSED', 'Domain cancelled by client.');
+ throw new AuthenticatorError('ERR_AUTH_DOMAIN_POPUP_CLOSED', 'Domain cancelled by client.');
  }
 
  throw new AuthenticatorError('ERR_AUTH_FAILED', 'Auth failed.');