Skip to content

Commit

Permalink
chore: remove html linting for now
Browse files Browse the repository at this point in the history
  • Loading branch information
SamuelAlev committed Mar 28, 2024
1 parent c8c38c3 commit 51d994f
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 48 deletions.
5 changes: 5 additions & 0 deletions .changeset/brown-pumas-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@frontify/eslint-config-basic": patch
---

fix: remove `html` plugin
15 changes: 1 addition & 14 deletions packages/basic/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {
browser: true,
node: true,
},
plugins: ['@typescript-eslint', '@html-eslint', 'unicorn', 'no-only-tests', 'promise', 'lodash', 'prettier'],
plugins: ['@typescript-eslint', 'unicorn', 'no-only-tests', 'promise', 'lodash', 'prettier'],
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
Expand Down Expand Up @@ -121,19 +121,6 @@ module.exports = {
'yml/indent': ['error', 4, { indicatorValueIndent: 2 }],
},
},
{
files: ['*.html'],
parser: '@html-eslint/parser',
extends: ['plugin:@typescript-eslint/disable-type-checked', 'plugin:@html-eslint/recommended'],
rules: {
'prettier/prettier': ['error', { parser: 'html' }],
'@html-eslint/indent': ['error', 4],
'@html-eslint/no-extra-spacing-attrs': ['error', { enforceBeforeSelfClose: true }],
// Conflict with Prettier
'@html-eslint/require-closing-tags': 'off',
'spaced-comment': 'off',
},
},
{
files: ['package.json'],
parser: 'jsonc-eslint-parser',
Expand Down
8 changes: 3 additions & 5 deletions packages/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,10 @@
"access": "public"
},
"peerDependencies": {
"eslint": ">=8.27.0",
"prettier": ">=3.0.0"
"eslint": "^8.56.0",
"prettier": "^3.0.0"
},
"dependencies": {
"@html-eslint/eslint-plugin": "^0.24.0",
"@html-eslint/parser": "^0.24.0",
"@typescript-eslint/eslint-plugin": "^7.4.0",
"@typescript-eslint/parser": "^7.4.0",
"eslint-config-prettier": "^9.1.0",
Expand All @@ -37,7 +35,7 @@
"eslint-plugin-no-only-tests": "^3.1.0",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-unicorn": "^51.0.0",
"eslint-plugin-unicorn": "^51.0.1",
"eslint-plugin-yml": "^1.13.2",
"yaml-eslint-parser": "^1.2.2"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
"access": "public"
},
"peerDependencies": {
"eslint": ">=8.27.0",
"prettier": ">=3.0.0",
"react": ">=18.2.0"
"eslint": "^8.26.0",
"prettier": "^3.0.0",
"react": "^18.2.0"
},
"dependencies": {
"@frontify/eslint-config-basic": "workspace:^",
Expand Down
4 changes: 2 additions & 2 deletions packages/vue2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
"access": "public"
},
"peerDependencies": {
"eslint": ">=8.27.0",
"prettier": ">=3.0.0"
"eslint": "^8.56.0",
"prettier": "^3.0.0"
},
"dependencies": {
"@frontify/eslint-config-basic": "workspace:^",
Expand Down
26 changes: 2 additions & 24 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 51d994f

Please sign in to comment.