HAL #34
HAL #34
Conversation
|
It's starting to look like a working backend now, but still the front end needs to be rewritten to handle the new HAL formatted JSON. |
| .then(function (result) { | ||
| res.json({'results': result, 'total': result.total}); | ||
| var links = { | ||
| self : '/retrospectives?page=' + page + '&limit=' + limit, |
There was a problem hiding this comment.
I think this string concat could be wrapped in a util function.
There was a problem hiding this comment.
yeah, and I'll look into moving the handling of limit+page+start somewhere else as well, so it's not duplicated both here and in getTickets
There was a problem hiding this comment.
Added lib\paginator with methods to handle 'item links' and 'bulk links' and the creation of 'start'
- parseInt req.query.page and req.query.limit
Fixed some smaller bugs with _links. Pop away the last result when we receive > limit results.
Fixed some bugs with _links.
| limit = 10, | ||
| page = 1; | ||
|
|
||
| if (req.query.page) { |
There was a problem hiding this comment.
we should probably add a check that req.query.page is within 1 and N where N is top most page for the result, but I think that belongs in another review.
The way it behaves now, if you have say 10 pages, and you send in ?page=30 it will create a previous link pointing to page=29 instead of redirecting you to page=10 and creating previous:9 which is probably a cleaner solution, but I consider this a edgecase for now.
Please don't just pull this in yet, as it's so far just a starting point, I will need to do a lot more work with it, but I wanted to share it with you early on to get some feedback.
The library 'express-hal' which I'm using here doesn't appear to be maintained, but it's a fairly short piece of code, I'm thinking that we can fork it and maintain it if we decide to use it.