Fix 'MainNav' and 'MobileNav' for consistent navigation #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Vishal-raj-1
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXISTING ISSUES:
It's important to note that the navigation bar in the project has a issue:
Frontend Freaksin the desktop view but showsMenuin mobile view.For example, the below is displayed in desktop.
But, in mobile view it looks like this.
And, if we click on
Menu, then the toggle menu in mobile view shows:CHANGES MADE:
To address this issue, I have made the following changes:
MainNavcomponent to display Frontend Freaks as the main navigation bar content in both desktop and mobile views.MobileNavcomponent to display Frontend Freaks as the main content in mobile view, maintaining consistency with the desktop view.Frontend Freaksis consistently displayed in both navigation bars, leaving no ambiguity.Here's how the fixed navigation bar will look:
And, if we click on
Frontend Freaks, then the toggle menu in mobile view shows:REQUEST:
Please review and merge this pull request at your earliest convenience. I have attached the screenshots for existing and updated navigation as well. Thank you for your attention to this enhancement, which addresses the issue of inconsistent navigation between desktop and mobile views in our website. I look forward to your suggestions and edits.