Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes trivia to interview question in all learn folders #84

Conversation

Hrithik0112
Copy link
Contributor

Fixes Issue

Changes

changes "trivia" name to "Interview Question" in All "Learn" folder i.e. Html basic ,CSS basic , CSS flex , CSS gird.

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2023-10-02 112205

Screenshot 2023-10-02 112137
![Screenshot 2023-10-02 112217](https://github.com/Front
Screenshot 2023-10-02 112229
endFreaks/Official-Website/assets/122002784/e4621dc9-9c3e-4da8-9d49-687a8c840c48)

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 3:05am

@@ -33,7 +33,9 @@ Want to improve this page?. Raise a issue on [@github](https://github.com/Manish
<TabsList>
<TabsTrigger value="learn">Learn</TabsTrigger>
<TabsTrigger value="assignment">Assignment</TabsTrigger>
<TabsTrigger value="InterviewQuestion">Interview Question</TabsTrigger>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra line

@@ -200,10 +202,12 @@ Want to improve this page?. Raise a issue on [@github](https://github.com/Manish

</TabsContent>

<TabsContent value="InterviewQuestion">
<TabsContent value="interview">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra line

@@ -187,6 +188,11 @@ Want to improve this page?. Raise a issue on [@github](https://github.com/Manish
<VideoPlayer src="https://youtu.be/ULp7wPJ-rzQ"/>
</TabsContent>

<TabsContent value="interview">
Interview Questions on css grid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be "CSS Grid"

@@ -299,6 +301,11 @@ Want to improve this page?. Raise a issue on [@github](https://github.com/Manish
Interview Questions on HTML
</TabsContent>

<TabsContent value="interview">
Interview Questions on html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be "HTML"

@@ -20,7 +20,9 @@ Want to improve this page?. Raise a issue on [@github](https://github.com/Manish
<TabsList>
<TabsTrigger value="learn">Learn</TabsTrigger>
<TabsTrigger value="assignment">Assignment</TabsTrigger>
<TabsTrigger value="InterviewQuestion">Interview Question</TabsTrigger>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra line

<TabsContent value="interview">
Interview Questions on css grid
</TabsContent>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra line

@@ -59,6 +60,10 @@ Want to improve this page?. Raise a issue on [@github](https://github.com/Manish

</TabsContent>

<TabsContent value="interview">
Interview Questions on css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be "CSS"

Copy link
Member

@Vishal-raj-1 Vishal-raj-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix all changes

@Hrithik0112
Copy link
Contributor Author

Understood.

@Hrithik0112
Copy link
Contributor Author

@Vishal-raj-1 done as you told. is there anything to improve ?

@Vishal-raj-1 Vishal-raj-1 merged commit 266204a into FrontendFreaks:master Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants