Added the feature : Added the clickable titles which collapse and expand on side bar nav #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making headings as Accordions on Side Bar Nav
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
In dark theme, title color should be white Fix this @Akash-pugazh
|
Vishal-raj-1
approved these changes
Oct 2, 2023
| <AccordionItem className="border-b-0" value="item-title"> | ||
| <div> | ||
| <AccordionTrigger className="py-2 hover:no-underline"> | ||
| {item.title} |
There was a problem hiding this comment.
title style is missing, "mb-1 rounded-md py-1 text-base font-medium dark:text-white"
|
Hello there Maintainers, I've made respective requested changes, Thankyou for guiding me out😊 Some Screenshots:
Please report if any other issues |
Vishal-raj-1
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue : Feat added : Added the clickable titles on Side bar nav
Closes #53
Changes proposed
Made changes on the sidebar-nav.tsx file : Making the UI element on sidebar as accordion
Edit : I've noticed a older issue on making the title clickable to open the content and Added in this second commit Please feel free to go through the code
Edit 2 : Sorry Ive Re-Submitting this due to merge conflicts. 😊
Quick note :
I have also made a little change on reducing the padding bottom from 8 to 4 (Line: 25), because it really looks more spaced when its large, Feel free to modify or I'll make sure to edit and PR again. 😊
Added SS for Reference:
Some little changes on UI code
Main Issue Fix :
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
This is minor change and also my first contribution, Thank you for this opportunity, will contribute more from here 💕