Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic.mdx ( Add Some important Selectors tags ) #244

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

Fuzaildev
Copy link
Contributor

@Fuzaildev Fuzaildev commented Oct 24, 2023

Update Some Important Selectors Tags that are used in CSS.

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Update Some Important Selectors Tags that are used in CSS.
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 2:35pm

@Fuzaildev Fuzaildev changed the title Update basic.mdx Update basic.mdx ( Add Some important Selectors tags ) Oct 24, 2023
Copy link
Member

@Vishal-raj-1 Vishal-raj-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix these changes

@@ -121,6 +121,38 @@ h1 {
color: green;
}

Add More important Selectors tags that really used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to add these two lines so remove it

}
/* Pseudo Selector */

/* If you visited the website then you can change the color */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pseudo Selector is discussed in link tag, so you can remove it from here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@Vishal-raj-1 Vishal-raj-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this change


/* Universal Selector (ALL Elements margin and padding are 0; ) */

{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you miss *

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Vishal-raj-1 Vishal-raj-1 merged commit 5690a71 into FrontendFreaks:master Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants