-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update basic.mdx ( Add Some important Selectors tags ) #244
Conversation
Update Some Important Selectors Tags that are used in CSS.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix these changes
content/batch/learn/css/basic.mdx
Outdated
@@ -121,6 +121,38 @@ h1 { | |||
color: green; | |||
} | |||
|
|||
Add More important Selectors tags that really used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to add these two lines so remove it
content/batch/learn/css/basic.mdx
Outdated
} | ||
/* Pseudo Selector */ | ||
|
||
/* If you visited the website then you can change the color */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pseudo Selector is discussed in link tag, so you can remove it from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix this change
content/batch/learn/css/basic.mdx
Outdated
|
||
/* Universal Selector (ALL Elements margin and padding are 0; ) */ | ||
|
||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you miss *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Update Some Important Selectors Tags that are used in CSS.
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers