updating content for string in dsa folder #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Vishal-raj-1
reviewed
Oct 4, 2023
content/batch/dsa/string.mdx
Outdated
|
|
||
| <div className="w-full h-full"> | ||
| <a href="https://www.youtube.com/watch?v=Unc365YFdf4" > | ||
| <img className="w-full h-full object-cover" src="https://camo.githubusercontent.com/266a84400260b3b6aa0d97332a19d301ee8f767d229083dfd58931781efea309/68747470733a2f2f696d672e796f75747562652e636f6d2f76692f556e6333363559466466342f302e6a7067" alt="JavaScript Loops" /> |
There was a problem hiding this comment.
In the src you have to add youtube video id, which is Unc365YFdf4 in this case.
http://img.youtube.com/vi/{YouTube_id}/0.jpg
so img tag will be like this
<img className="w-full h-full object-cover" src="http://img.youtube.com/vi/Unc365YFdf4/0.jpg" alt="Strings in JavaScript" />
Vishal-raj-1
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Perfect, Good Progress @nsundriyal62
You don't need to feel sorry or bad.
As a beginner, It happens with everyone.
Just update the image tags, rest everything is fine.
This reverts commit 5ff061e. modified: content/batch/dsa/string.mdx
Vishal-raj-1
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
Changes proposed
Check List (Check all the applicable boxes)
] The title of my pull request is a short description of the requested changes.
Screenshots
Note to reviewers
sorry sir for creating a mess but i am just new to github and confused with these commit and all. i try to keep it simple and correct.
makes all changes as you mentioned
thanks for being patience sir.