Skip to content

Commit

Permalink
Merge pull request #72 from FrontendFreaks/ManishBisht777-patch-2
Browse files Browse the repository at this point in the history
docs: CONTRIBUTING.md
  • Loading branch information
Vishal-raj-1 authored Oct 2, 2023
2 parents c4511cb + d796b63 commit 381dc9a
Showing 1 changed file with 44 additions and 0 deletions.
44 changes: 44 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Contributing Guide

## Issues & Pull Requests

### Creating an Issue

Before **creating** an Issue for `features`/`bugs`/`improvements` please follow these steps:

1. search existing Issues before creating a new issue (has someone raised this already)
1. if it doesn't exist create a new issue giving as much context as possible (please select the correct Issue type, for example `bug` or `feature`)

### Working on an Issue (get it assigned to you)

Before working on an existing Issue please follow these steps:

1. only ask to be assigned 1 issue at a time
1. comment asking for the issue to be assigned to you (do not tag maintainers on GitHub or Discord as all maintainers receive your comment notifications)
1. after the Issue is assigned to you, you can start working on it
1. **only** start working on this Issue (and open a Pull Request) when it has been assigned to you - this will prevent confusion, multiple people working on the same issue and work not being used
1. do **not** enable GitHub Actions on your fork
1. reference the Issue in your Pull Request (for example `closes #123`)

> Notes:
> - check the `Assignees` box at the top of the page to see if the issue has been assigned to someone else before requesting this be assigned to you
> - if an Issue is unclear, ask questions to get more clarity before asking to have the Issue assigned to you
> - only request to be assigned an Issue if you know how to work on it
> - an Issue can be assigned to multiple people, if you all agree to collaborate on the issue (the Pull Request can contain commits from different collaborators)
> - any Issues that have no activity after 2 weeks will be unassigned and re-assigned to someone else
## Reviewing Pull Requests

We welcome everyone to review Pull Requests, it is a great way to learn, network and support each other.

### DOs

- be kind and respectful, we use inclusive, gender neutral language (for example `they/them` instead of `guy/man`)
- use inline comments to explain your suggestions
- use inline suggestions to propose changes

### DON'Ts

- do not be rude, disrespectful or aggressive
- do not repeat feedback, this creates more noise than value (check the existing conversation), use GitHub reactions if you agree/disagree with a comment
- do not blindly approve pull requests to improve your GitHub contributors graph

0 comments on commit 381dc9a

Please sign in to comment.