Skip to content

Commit

Permalink
Swap order of newVolumes representation in summary table rockstor#2933
Browse files Browse the repository at this point in the history
The internal:external representation of volumes:shares in the summary
table showed at the end of the Add Storage to a Rock-On process was
the inverse to what it should have been (inverse of table headers).
This commit swaps the order in the underlying JS object to correct this.
  • Loading branch information
FroggyFlox committed Dec 27, 2024
1 parent 812f1cf commit 3fb8123
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1200,7 +1200,7 @@ RockonAddShare = RockstorWizardPage.extend({
return $.Deferred().reject();
}
this.share_map = this.model.get('shares');
this.share_map[this.$('#volume').val()] = this.$('#share').val();
this.share_map[this.$('#share').val()] = this.$('#volume').val();
this.model.set('shares', this.share_map);
return $.Deferred().resolve();
}
Expand Down Expand Up @@ -1617,7 +1617,7 @@ RockonSettingsSummary = RockstorWizardPage.extend({
initHandlebarHelpers: function() {
Handlebars.registerHelper('display_newVolumes', function() {
// Display newly-defined shares and their corresponding mapping
// for confimation before submit in settings_summary_table.jst
// for confirmation before submit in settings_summary_table.jst
var html = '';
for (share in this.new_volumes) {
html += '<tr>';
Expand All @@ -1630,7 +1630,7 @@ RockonSettingsSummary = RockstorWizardPage.extend({
});
Handlebars.registerHelper('display_newLabels', function() {
// Display newly-defined labels and their corresponding container
// for confimation before submit in settings_summary_table.jst
// for confirmation before submit in settings_summary_table.jst
var html = '';
for (new_label in this.new_labels) {
html += '<tr>';
Expand Down

0 comments on commit 3fb8123

Please sign in to comment.