Request for granting access token can contain JSON body. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This behaviour is not described in the RFC nor in the drafts. |
|
Yeah I know it's not described in the official docs, but some APIs out there provide the functionalilty. And it does make sense if everything in your API is json, to have the oauth endpoints support json as well. |
|
Can you please merge this? Even though this behaviour is not described in the RFC, all APIs accept this type of request Should we change our front code only to OAuth ? this is restrictive. #111 duplicate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. I modified the grantAccessToken method a little bit to accept both post and json bodies.