Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: mark test as incomplete #265

Closed
wants to merge 1 commit into from
Closed

tests: mark test as incomplete #265

wants to merge 1 commit into from

Conversation

Chris53897
Copy link
Contributor

Does someone know how to fix this?

What changed until last CI run 6 Months ago?
https://github.com/FriendsOfSymfony/FOSCKEditorBundle/actions/runs/9060110284

@xabbuh xabbuh mentioned this pull request Jan 13, 2025
Merged
@xabbuh
Copy link
Member

xabbuh commented Jan 13, 2025

I assume that there is more than one identifier on the ckeditor.com website to reference a custom build and that for some time they changed which one is embedded in the build-config.js file. #269 will update the tests accordingly. Thank you for trying to fix this.

@xabbuh xabbuh closed this Jan 13, 2025
xabbuh added a commit that referenced this pull request Jan 13, 2025
@xabbuh
minor #269 update custom build ids (xabbuh)
3a082a4 
This PR was merged into the 2.x branch.

Discussion
----------

update custom build ids

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets |
| License       | MIT

replaces #265

Commits
-------

f739f57 update custom build ids
@Chris53897
Copy link
Contributor Author

thanks @xabbuh

@Chris53897 Chris53897 deleted the fix/ci branch January 13, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chris53897 @xabbuh @Chris8934