Fix Condition when Text Preview should be shown (#396)

* Update FormatTextPreview.php * chore: refactor & fix logic with blank lines * style: formatting --------- Co-authored-by: Davide Iadeluca <[email protected]>
FriendsOfFlarum · Nov 4, 2024 · 6710366 · 6710366
1 parent 3cd6cdc
commit 6710366
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/Formatter/TextPreview/FormatTextPreview.php b/src/Formatter/TextPreview/FormatTextPreview.php
@@ -44,17 +44,14 @@ public function __invoke(Renderer $renderer, $context, string $xml)
 
             if ($file) {
                 $file_contents = file_get_contents($this->paths->public.'/assets/files/'.$file->path);
+                $lines = preg_split('/\R/', $file_contents);
+                $lines = array_filter($lines, 'trim');
 
-                $file_contents_normalised = str_replace(["\r\n", "\r", "\n"], "\n", $file_contents);
-
-                // automatically normalises line endings
-                $lines = explode("\n", $file_contents_normalised);
-                $first_five_lines = array_slice($lines, 0, 5);
-                $snippet = implode("\n", $first_five_lines);
-
-                if ($snippet !== $file_contents_normalised) {
+                if (count($lines) <= 5) {
                     $attributes['has_snippet'] = 'false';
                 }
+
+                $snippet = implode("\n", array_slice($lines, 0, 5));
             }
 
             $attributes['snippet'] = $snippet;