fix: link fails due to forgetting before reading

FriendsOfFlarum · Nov 15, 2023 · 21b9e3b · 21b9e3b
1 parent 3c74c8f
commit 21b9e3b
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/Controllers/AbstractOAuthController.php b/src/Controllers/AbstractOAuthController.php
@@ -327,10 +327,8 @@ protected function handleOAuthResponse(ServerRequestInterface $request, AccessTo
  // Don't register a new user, just link to the existing account, else continue with registration.
  if ($sessionLinkToExists && $actor->exists) {
  $actor->assertRegistered();
- // forget the linkTo key
- $this->forget(self::SESSION_LINKTO, $session);
-
  $sessionLink = (int) $this->get(self::SESSION_LINKTO, $session);
+ $this->forget(self::SESSION_LINKTO, $session);
 
  if ($actor->id !== $sessionLink || $sessionLink === 0) {
  throw new ValidationException(['linkAccount' => 'User data mismatch']);