fix: search gambit does not function as intended when negated

FriendsOfFlarum · Sep 26, 2024 · b970103 · b970103
1 parent 2830be7
commit b970103
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Search/BestAnswerFilterGambit.php b/src/Search/BestAnswerFilterGambit.php
@@ -49,14 +49,15 @@ protected function conditions(SearchState $search, array $matches, $negate)
  $actor = $search->getActor();
 
  $search->getQuery()->where(function ($query) use ($negate, $actor) {
- $method = $negate ? 'whereNull' : 'whereNotNull';
+ $method = $negate ? 'whereNotIn' : 'whereIn';
+ $methodBestAnswerPostId = $negate ? 'whereNull' : 'whereNotNull';
 
- $query->whereIn('id', function ($query) use ($actor) {
+ $query->$method('discussions.id', function ($query) use ($actor) {
  $query->select('discussion_id')
  ->from('discussion_tag')
  ->whereIn('tag_id', $this->allowedQnATags($actor))
  ->pluck('discussion_id');
- })->$method('best_answer_post_id');
+ })->$methodBestAnswerPostId('discussions.best_answer_post_id');
  });
  }