Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop user IP banning #18

Closed
wants to merge 7 commits into from
Closed

Drop user IP banning #18

wants to merge 7 commits into from

Conversation

imorland
Copy link
Member

@imorland imorland commented May 27, 2021

wip

  • Remove ban user using IP x.x.x.x - Either an IP address is banned or not
  • Add an optional splash notifying a guest/user that their IP is restriced
  • Ensure that a user accessing from a banned IP has no permissions during that request
  • Drop user_id column
  • Cleanup BanUserModal and UnbanUserModal
  • ...
  • ...

@imorland imorland linked an issue May 27, 2021 that may be closed by this pull request
@imorland imorland changed the title Flarum 1.0 Drop user IP banning Jun 25, 2021
@dsevillamartin
Copy link
Member

I am interested in doing this. I was looking through this and did note some things that I feel would be good to keep - banned badge, showing banned users in admin (though probably updated to be affected users based on post history and not the DB relationship)

@DavideIadeluca
Copy link
Member

With the 2.x upgrade being in front of us, I don't think it makes sense anymore to bring this PR up to date. @imorland hope you don't mind me closing this.

Are you generally still looking to introduce this change? If so, I propose to do it after/with the 2.x upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta 16 support tracker for @flarum
3 participants