Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Add device s200 #711

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add device s200 #711

wants to merge 1 commit into from

Conversation

albertsal
Copy link
Contributor

I added the s200 sport device management similar to the MAKIBESF68 ..

I modified the showIncomingCall logic, showText,
encodeStringToDevice.

The device works in unicode but for incoming calls is mixed

I added the s200 sport device management similar to the MAKIBESF68 ..

I modified the showIncomingCall logic, showText,
encodeStringToDevice.

The device works in unicode but for incoming calls is mixed
@ashimokawa
Copy link
Contributor

Thanks!

Can you please remove all the formatting changes? Whitespaces and tabs.

Also please do the same indention as we do (default Android Studio)

@albertsal
Copy link
Contributor Author

@ashimokawa sorry ... i use project settings ... can you tell me the parameters to set?

Copy link
Contributor

@cpfeiffer cpfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool and looks good to me.

The formatting changes are actually the cause of using the project default formatting rules, so actually make it consistent. It would've been better to have the formatting changes separate from content changes, but it's always a pain to do this after the fact.

One question, also directed at @jpbarraca -- do you prefer to have DeviceType checks in the code or prefer using separate classes per device (or per device that is different enough to warrant a separate class).

I always prefer to separate things to prevent many if-clauses, but if the number of if-clauses stays small, it's OK.

Any other comments @jpbarraca?

@jpbarraca
Copy link
Contributor

I prefer having different classes overriding the default behaviour whenever necessary. Especially in this case where the number of different devices may be large.

The rest of the code seems to be ok.

@ashimokawa
Copy link
Contributor

@jpbarraca
Welcome back ;)
Do you want to merge this and then change the code according to your taste?

About the indention, it would be cool if you could use the same style as android studio default which we are using to prevent unrelated formatting changes from happening.

@jpbarraca
Copy link
Contributor

@albertsal How can we distinguish the S200 from the other HPLUS devices?

@albertsal
Copy link
Contributor Author

As for the MAKIBESF68 also s200 starts with SPORT

@jpbarraca
Copy link
Contributor

Is there an additional message supported? or a characteristic? If nothing is available we will have to resort to a configuration option.

What is the hardware and firmware versions?

@albertsal
Copy link
Contributor Author

I attach the information I get

88820170718_222740
gadgetbridge.txt

@jpbarraca
Copy link
Contributor

I find it odd that this is required (mixed language support). Also I find not accurate method to identify the device type.
What is the problem that you find with the current version?
Also, can you please try this version ?

@albertsal
Copy link
Contributor Author

For messages it requires unicode but for calls if I use unicode he writes in chinese
Ok I try your version

@albertsal
Copy link
Contributor Author

albertsal commented Jul 20, 2017

When I receive a message, the message is displayed with spaces .... I have solved this problem by applying the first 2 bytes characteristic of the unicode only at the beginning of the message the remaining characters apply only the final 0 .... do Reference to my code ...

Regarding Chinese call visualization calls (this problem is also visible with hplus) I have solved not using unicode for this function

I forgot s200 does not support concatenated messages so I set a maximum number of characters to use all the space ... I also inserted small optimizations like truncating the message object to use the best available space

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants