Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subdomain resolution #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mdatsev
Copy link

@mdatsev mdatsev commented Mar 27, 2023

Here's the code to test it:

const { Web3Resolver } = require("./lib/index.js");
const web3resolver = new Web3Resolver();

(async () => {
  console.log("domain: ", await web3resolver.resolve("test8888.888"))
  console.log("subdomain: ", await web3resolver.resolve("888.test8888.888"))
})();

@alessandrovisentini alessandrovisentini self-assigned this Mar 30, 2023
@alessandrovisentini alessandrovisentini added the enhancement New feature or request label Mar 30, 2023
Copy link
Contributor

@alessandrovisentini alessandrovisentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add SUB_DOMAINED_DOMAIN to the ResolvedResourceType enum and add the case to handle subdomains in the getResolvedResourceType() function in name-tools.ts

@alessandrovisentini alessandrovisentini removed their assignment Jun 22, 2023
Copy link

@SamuelBeasley89 SamuelBeasley89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Still needs another set of eyes! Mine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants