freertos-kernel: Update to V11.1.0 release
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though CMake supports circular dependency, but currently it is supported only for static libraries. If CMake detects a circular dependency which involves an object library then CMake stops. For more info, check https://gitlab.kitware.com/cmake/cmake/-/issues/17905. With FreeRTOS-Kernel 11.1.0 release, FreeRTOS-Kernel produces a single static library. As part of this effort, `freertos_kernel_port` library has been changed to an `OBJECT` library. With our current dependency chain in FRI, this leads to a circular dependency with an object library. Therefore, remove the dependency of `freertos_config` on `fri-bsp` to avoid this. Because of this, we've to add the necessary includes from bsp to `freertos-config`. The CS315 network interface layer inside the FreeRTOS TCP/IP stack https://github.com/FreeRTOS/FreeRTOS-Plus-TCP/blob/main/source/portable/NetworkInterface/MPS4_CS315/Device/Include/SSE315.h#L62 is done in such a way that it depends on fri-bsp. Therefore, add `freertos_plus_tcp` dependency on `fri-bsp`. In general, a library A depending on another library B should avoid linking against granular libraries defined inside the library B. This can cause build failures in future. Therefore, the dependency of `isp_platform_driver_system` and `isp_control` on `freertos_kernel_include` has been changed to `freertos_kernel`. Signed-off-by: Devaraj Ranganna <[email protected]>
amazonKamath
approved these changes
May 9, 2024
aggarg
approved these changes
May 9, 2024
amazonKamath
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even though CMake supports circular dependency, but currently it is supported only for static libraries. If CMake detects a circular dependency which involves an object library then CMake stops. For more info, check https://gitlab.kitware.com/cmake/cmake/-/issues/17905.
With FreeRTOS-Kernel 11.1.0 release, FreeRTOS-Kernel produces a single static library. As part of this effort,
freertos_kernel_portlibrary has been changed to anOBJECTlibrary. With our current dependency chain in FRI, this leads to a circular dependency with an object library. Therefore, remove the dependency offreertos_configonfri-bspto avoid this. Because of this, we've to add the necessary includes from bsp tofreertos-config.The CS315 network interface layer inside the FreeRTOS TCP/IP stack https://github.com/FreeRTOS/FreeRTOS-Plus-TCP/blob/main/source/portable/NetworkInterface/MPS4_CS315/Device/Include/SSE315.h#L62 is done in such a way that it depends on fri-bsp. Therefore, add
freertos_plus_tcpdependency onfri-bsp.In general, a library A depending on another library B should avoid linking against granular libraries defined inside the library B. This can cause build failures in future. Therefore, the dependency of
isp_platform_driver_systemandisp_controlonfreertos_kernel_includehas been changed tofreertos_kernel.Test Steps
Changes validated on internal CI, no regression observed.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.