-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export RSA key attributes from mbedtls context to support TLSv1.3 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 94.02% 96.77% +2.75%
==========================================
Files 3 3
Lines 1690 1736 +46
Branches 442 456 +14
==========================================
+ Hits 1589 1680 +91
+ Misses 17 0 -17
+ Partials 84 56 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gaurav Aggarwal <[email protected]>
kar-rahul-aws
approved these changes
Oct 16, 2024
aggarg
approved these changes
Oct 16, 2024
aggarg
changed the title
Populate RSA key from mbedtls context to support TLSv1.3
Export RSA key attributes from mbedtls context to support TLSv1.3
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presently the library is not able to support TLSv1.3, this is because it does not allow exporting RSA public attributes. It does not populate the attribute values for an RSA key using the
mbedtls_rsa_context
due to which the certificate verification fails.This PR adds a new function that populates attribute values for an RSA key from the mbed TLS context.
Test Steps
For now it is only tested using the the corePKCS MQTT Mutual Auth Demo that builds with the changes and is able to create a successful TLS connection with the broker.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.