Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export RSA key attributes from mbedtls context to support TLSv1.3 #202

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

DakshitBabbar
Copy link
Member

@DakshitBabbar DakshitBabbar commented Oct 10, 2024

Description

Presently the library is not able to support TLSv1.3, this is because it does not allow exporting RSA public attributes. It does not populate the attribute values for an RSA key using the mbedtls_rsa_context due to which the certificate verification fails.

This PR adds a new function that populates attribute values for an RSA key from the mbed TLS context.

Test Steps

For now it is only tested using the the corePKCS MQTT Mutual Auth Demo that builds with the changes and is able to create a successful TLS connection with the broker.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

kar-rahul-aws and others added 6 commits October 14, 2024 06:33
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (e0cd4db) to head (65d4ac7).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   94.02%   96.77%   +2.75%     
==========================================
  Files           3        3              
  Lines        1690     1736      +46     
  Branches      442      456      +14     
==========================================
+ Hits         1589     1680      +91     
+ Misses         17        0      -17     
+ Partials       84       56      -28     
Flag Coverage Δ
unit_tests 96.77% <100.00%> (+2.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aggarg aggarg merged commit 470ccc3 into FreeRTOS:main Oct 16, 2024
14 checks passed
@aggarg aggarg changed the title Populate RSA key from mbedtls context to support TLSv1.3 Export RSA key attributes from mbedtls context to support TLSv1.3 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants