Remove dependency on config from coreMQTT headers #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archigup
force-pushed
the
clean-api-config
branch
3 times, most recently
from
6662804
to
070e3ba
Compare
The NetworkContext struct should be defined in each c file, not in the config h file. The API uses it as an opaque type. CMock needs a workaround for it's c files though, as it does not support opaque types.
archigup
force-pushed
the
clean-api-config
branch
2 times, most recently
from
f8afe05
to
a08bb48
Compare
rawalexe
approved these changes
Feb 1, 2024
The NetworkContext struct should be defined in each c file, not in the config h file. The API uses it as an opaque type.
core_mqtt_serializer.h included the user coreMQTT config, which spills the config header's contents into all consumers of coreMQTT's headers. Macros from the config are no longer used in the the API, so this is also no longer used for anything, so can be removed.
The loggging defaults were split out since they are not namespaced to coreMQTT, and they previously leaked to all files including a coreMQTT header. Splitting them allowed the logging defaults to only be pulled into coreMQTT source files. Now that no header files use the config headers, and thus all coreMQTT config only affects coreMQTT source files, the split is no longer needed.
archigup
force-pushed
the
clean-api-config
branch
from
a08bb48
to
a56cc28
Compare
AniruddhaKanhere
approved these changes
Feb 1, 2024
rawalexe
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core_mqtt_serializer.hincluded the user coreMQTT config, which spillsthe config header's contents into all consumers of coreMQTT's headers.
Macros from the config are no longer used in the the API, so this is
also no longer used for anything, so can be removed.
The loggging defaults were split out since they are not namespaced to
coreMQTT, and they previously leaked to all files including a coreMQTT
header. Splitting them allowed the logging defaults to only be pulled
into coreMQTT source files. Now that no header files use the config
headers, and thus all coreMQTT config only affects coreMQTT source
files, the split is no longer needed.