Add MLDv1 support for IPv6 multicast #1205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to FreeRTOS#1047 Add MLDv1 support for IPv6 multicast group management. * Add `vJoinMulticastGroup` and `vLeaveMulticastGroup` functions in `source/FreeRTOS_IPv6_Utils.c` to handle MLDv1 group joining and leaving. * Update `source/FreeRTOS_IPv6.c` to include `vSendMLDv1Report` and `vSendMLDv1Done` functions for sending MLDv1 report and done messages. * Declare `vJoinMulticastGroup` and `vLeaveMulticastGroup` functions in `source/include/FreeRTOS_IPv6_Utils.h`. * Add MLDv1 group management function declarations in `source/include/FreeRTOS_IPv6.h`. Signed-off-by: Vishwanath Martur <[email protected]>
vishwamartur
force-pushed
the
add-mldv1-support
branch
from
55b7d88
to
b095659
Compare
| void vSendMLDv1Report( const struct xNetworkEndPoint * pxEndPoint, | ||
| const IPv6_Address_t * pxAddress ) | ||
| { | ||
| /* Implementation of MLDv1 report sending. */ |
There was a problem hiding this comment.
Why is the implementation left out?
| void vSendMLDv1Done( const struct xNetworkEndPoint * pxEndPoint, | ||
| const IPv6_Address_t * pxAddress ) | ||
| { | ||
| /* Implementation of MLDv1 done message sending. */ |
|
Please share how you have verified these changes. Also, PR #1019 adds support for a wider range of multicast functionalities and is already in progress. Please take a look at that PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1047
Add MLDv1 support for IPv6 multicast group management.
vJoinMulticastGroupandvLeaveMulticastGroupfunctions insource/FreeRTOS_IPv6_Utils.cto handle MLDv1 group joining and leaving.source/FreeRTOS_IPv6.cto includevSendMLDv1ReportandvSendMLDv1Donefunctions for sending MLDv1 report and done messages.vJoinMulticastGroupandvLeaveMulticastGroupfunctions insource/include/FreeRTOS_IPv6_Utils.h.source/include/FreeRTOS_IPv6.h.