Pledge optional #15
Merged
Pledge optional #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CooperSmout
approved these changes
Oct 1, 2020
Comment on lines
-128
to
+129
| implication = models.FloatField(verbose_name='Threshold') | ||
| author_position = models.ManyToManyField(EnabledAuthorPosition) | ||
| implication = models.FloatField(verbose_name='Threshold', blank=True, default=None) | ||
| author_position = models.ManyToManyField(EnabledAuthorPosition, blank=True, default=None) |
There was a problem hiding this comment.
This doesn't seem to be changing the behaviour when i run the app locally via docker ... Should it?
I'm running the docker container using the instructions in CONTRIBUTING.md, then going to the app at http://penguin.termina.linux.test:8080/.
When I go to pledge on one of the fake campaign pages (e.g. http://penguin.termina.linux.test:8080/pledge/step-specific-woman-arrive-american), the same three dynamic texts pop up (threshold, author position, public name). I also checked the Site administration (CMS) settings, but can't see an option to remove these texts for a particular campaign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8. The simplified flow we can do in another PR alongside with visual changes.