Bugfix: Node.set_value() does not work with enumerations #888
Conversation
If a client tries to set a enum variable without explicitly force the data type it becomes implicit converted to a ua.Variant.Int64. The server expects an Int32 for an enum value. This is why set_value() crashes if you try to set an enum value using a integer literal like "set_value(2)". The enumeration seems to need a special treadment at this point. See ua_utils.py def data_type_to_variant_type(). If no data type was given in method set_value(), this change checks the data type of the node object and automatically converts the value argument to the correct target data type of the server.
|
Can anyone please review this PL? My client is doing fine with this change. The unit tests have also gone through successfully (on my machine). However, in my opinion, a test for setting an enumerarion unsing an integer literal lacks. Can someone help with implementing a test for the change? |
|
The tests that fail here also fail with the main branch without any changes. Does anyone have an explanation for this? The negative results of the tests seem to habe another cause the my changes. |
|
Thanks for the PR but I am a bit afraid of that one. you are introusing a second network operation on a write call... |
Oh dear, I did not know that. How could this be done without a second network operation? |
|
Maybe it is impossible.... But maybe we should write numbers with unspecified data types as 4 bytes by default. 32 seems to be the default in opcua... |
If a client tries to set a enum variable without explicitly force the data type it becomes implicit converted to a ua.Variant.Int64. The server expects an Int32 for an enum value. This is why set_value() crashes if you try to set an enum value using a integer literal like "set_value(2)".
The enumeration seems to need a special treadment at this point. See ua_utils.py def data_type_to_variant_type().
If no data type was given in method set_value(), this change checks the data type of the node object and automatically converts the value argument to the correct target data type of the server.