Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swig rebottle, and fix test for gnu+linux #505

Closed
wants to merge 1 commit into from

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented May 1, 2024

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch
Copy link
Collaborator Author

ipatch commented May 1, 2024

https://github.com/FreeCAD/homebrew-freecad/actions/runs/8914059167


Error
mxschmitt/action-tmate@v3 is not allowed to be used in FreeCAD/homebrew-freecad. Actions in this workflow must be: within a repository owned by FreeCAD, created by GitHub, verified in the GitHub Marketplace, or matching the following: homebrew/actions/*, dawidd6/action-send-mail@v2.

@ipatch ipatch force-pushed the swig.rebottle branch 2 times, most recently from cea11ea to 1f95e13 Compare May 1, 2024 20:04
@ipatch
Copy link
Collaborator Author

ipatch commented May 1, 2024

used the below github action to manually build the bottle on the github provided runner using test-bot. not sure what is causing the build failure while checking for dependents.

https://github.com/mxschmitt/action-tmate

@ipatch ipatch self-assigned this May 1, 2024
@ipatch ipatch added the pr-pull label May 1, 2024
@github-actions github-actions bot closed this in 8f8b567 May 1, 2024
@ipatch ipatch deleted the swig.rebottle branch May 3, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant