Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind11 version formula to use py310 #464

Closed
wants to merge 1 commit into from

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Dec 21, 2023

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch ipatch force-pushed the pybind11.py310 branch 2 times, most recently from 57eb62b to dfd90e6 Compare December 21, 2023 22:26
@ipatch
Copy link
Collaborator Author

ipatch commented Dec 21, 2023

attempt to fix below error,

  example.cpp:1:10: fatal error: 'pybind11/pybind11.h' file not found
  #include <pybind11/pybind11.h>
           ^~~~~~~~~~~~~~~~~~~~~
  1 error generated.

drop trailing pybind11 from path

@ipatch ipatch force-pushed the pybind11.py310 branch 2 times, most recently from 44e4649 to 859c0b0 Compare December 21, 2023 23:04
@ipatch
Copy link
Collaborator Author

ipatch commented Dec 21, 2023

mojave build error

  -- Installing: /usr/local/Cellar/pybind11_py310/2.11.1/share/pkgconfig/pybind11.pc
  ==> /usr/local/opt/[email protected]/libexec/bin/python -m pip install --verbose --no-deps --no-binary=:all: --ignore-installed --no-compile --prefix=/usr/local/Cellar/pybind11_py310/2.11.1/libexec --no-build-isolation .
  dyld: Library not loaded: /usr/local/opt/gettext/lib/libintl.8.dylib
    Referenced from: /usr/local/Cellar/[email protected]/3.10.9/Frameworks/Python.framework/Versions/3.10/Python
    Reason: image not found

possible fix 🤞

  on_macos do
    depends_on "gettext" if MacOS.version == :mojave
  end

@ipatch
Copy link
Collaborator Author

ipatch commented Dec 22, 2023

mojave error,

 -- Installing: /usr/local/Cellar/pybind11_py310/2.11.1/share/pkgconfig/pybind11.pc
  ==> /usr/local/opt/[email protected]/libexec/bin/python -m pip install --verbose --no-deps --no-binary=:all: --ignore-installed --no-compile --prefix=/usr/local/Cellar/pybind11_py310/2.11.1/libexec --no-build-isolation .
  /usr/local/opt/[email protected]/bin/python3.10: No module named pip

@ipatch ipatch self-assigned this Dec 24, 2023
@ipatch ipatch added the pr-pull label Dec 24, 2023
@github-actions github-actions bot closed this in f239e66 Dec 24, 2023
@ipatch ipatch deleted the pybind11.py310 branch December 24, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant