Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better codeOf by re-creating the original config file #1876

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

maximiliankaul
Copy link
Contributor

Originally, we simply used toString() on the ini4j objects. However, this does not work in all cases.
This PR tries to re-create the original INI code given the ini4j objects.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.37%. Comparing base (af0bcd9) to head (6267c40).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../aisec/cpg/frontend/configfiles/IniFileFrontend.kt 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../aisec/cpg/frontend/configfiles/IniFileFrontend.kt 74.46% <80.00%> (+0.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximiliankaul maximiliankaul enabled auto-merge (squash) December 2, 2024 13:22
@maximiliankaul maximiliankaul merged commit 05631c5 into main Dec 2, 2024
2 checks passed
@maximiliankaul maximiliankaul deleted the mk/iniCode branch December 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants