-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We build for china #490
Open
cornercube
wants to merge
18
commits into
Foundation-19:master
Choose a base branch
from
cornercube:chinastuff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
We build for china #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
makes chairmain cheng proud of us
makes the type-17 chinese pistol load from stripper clips into an internal magazine as per the game/real life
a debuff since you cant load extended mags into it, though it has a very niche upside of being able to load free bullets into it by hand without the need for magazines
also adds 10-rnd stripper clips for use in the type-17 (zip gun clip as a placeholder, until someome makes a nice looking one)
not china related, but stats for a laser carbine were also added
adds the chinese militant outfit, for more chinese swag
sprite courtesy of infrared baron
Why It's Good For The Game
-chinese pistol is no longer a 10mm pistol clone, more of a semi-clone now
allows you to say you are loading a clip without being wrong
lore compliant
-new outfit to wear if you like being chinese, inspired by an F76 outfit
-minor bugfixes, while we are at it
Pre-Merge Checklist
Changelog
🆑
add: 10-round, 10mm ammo clip
add: chinese militant suit and cap
add: FO4 laser gun (laser carbine) added for testing
change: chinese pistol now accepts stripper clips
del: some unnecessary lines from the chinese officer hat and uniform
fix: chinese officer sword inhand shows up now
/:cl: