Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge Quality of Life improvement to the game. #353

Closed

Conversation

iMoeMoe
Copy link
Contributor

@iMoeMoe iMoeMoe commented Nov 15, 2023

About The Pull Request

-Adding more Broken Machine parts to salvage
-Adding Gaia to the Vendor (in contraband)
-Give NCR their Chem Dispenser
-Map out Khan's River to prevent loot bypass

StrongDMM_tgfxkeJ6oJ

-Tiny Loot relocation at the Deathclaw Mother Den (Move Gun loot deeper to prevent dungeon skip)

StrongDMM_4szdtnGNDJ

-Add lootboxes (tier 1-3 gun,melee and armour lootboxes) and Salvage Parts to vendor

Why It's Good For The Game

Decreasing the grind and the need to dungeon run and farming, allowing more time for players to enjoy roleplaying and fighting each other.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: Added more options in vendor
add: Added Gaia to vendor
add: Added lootboxes to vendor
added: Drug Trade motherclaw to Khan River
tweak: tweaked loot spawn
/:cl:

@iMoeMoe
Copy link
Contributor Author

iMoeMoe commented Nov 15, 2023

idk why this one is github not being able to run this one, it ran fine on my test

dreamseeker_ToV18p9oHj

@RememberZero
Copy link

RememberZero commented Nov 16, 2023

I doubt giving NCR a free chem machine or giving all hydroponics vendors five farming bypass seeds for anyone with a screwdriver and multitool is going to give free time that will convert into roleplay.

...Also, why the quiet 100 cap firebombs at the weapons vendor?

@iMoeMoe
Copy link
Contributor Author

iMoeMoe commented Nov 16, 2023

I doubt giving NCR a free chem machine or giving all hydroponics vendors five farming bypass seeds for anyone with a screwdriver and multitool is going to give free time that will convert into roleplay.

...Also, why the quiet 100 cap firebombs at the weapons vendor?

the fire bomb is a quick fix, someone broke it a while ago and didn't bother fixing it

dreamseeker_DP3Ar9S02x

and I believe putting gaia in place will allow players to care less about having to do botany to do everything else as botany contributes half the game to the player in term of healing and without it, it basically handicap the player. With this addition, it allows players to enjoy the game more without having to be forced to do botany every single round to be relevant to the game. and with this addition to all faction, it'll help the game be less tedious and inclusive to all faction and even wastelanders. It'll help the players enjoy fighting AND roleplaying.

@ErwinSnowden
Copy link
Contributor

Other than roundstart gaia being bad for obvious reasons especially when it's already dungeon loot in several areas-

This has several undocumented changes, the most notable being:

Organ Trading Vendor - This can be used to obtain infinite caps rather easily as it accepts cybernetic organs which can be made with metal and glass at any protolathe, and with an organ storage bag they can be transported in batches of 100. You can buy metal and glass in bulk or simply get it from salvage and the ratio is a net profit.

Random NCR Corpse - This can be used to obtain NCR fatigues incredibly early on depending on placement, why?

Holy water - I'm assuming you placed this here in bad faith so you could manufacture strange reagent, as you seem to have snuck in holy water in other locations using your pulls. I think you should be more transparent about that.

Advanced Chem-Master - In the NCR. This has the option of superstims, which contain more chemicals and is different than the normal chem-master. This only talks about dispensers and not this

High quality/Tool salvage from the generic crafting vendor - High quality means you can slot in 1000 caps (not hard to do) and obtain something like 8-9 research documents as well as a TON of weapon crafting components that you can buy for MUCH, MUCH, MUCH higher prices at other vendors. (detailed here:
image )
The tool salvage is also questionable, but not downrightly objectionable unlike the first. Tool salvage gives you tools that are similar to alien tools, incredibly fast. Normally they are incredibly limited and rare, only being obtainable from salvaging terminals and computers in ruins.

@Aurrain Aurrain added Bug Something isn't working Merge Conficts This PR currently has ongoing merge clonflicts Mapping this PR changes the map Balance this PR is aimed at balancing one or more aspect of the game Opinion This issue is based on the opinions of the author and therefore subjective in nature labels Dec 7, 2023
@xTrainx
Copy link
Contributor

xTrainx commented Mar 16, 2024

please resolve the merge conflics by sunday or the pr will be closed

@xTrainx xTrainx closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance this PR is aimed at balancing one or more aspect of the game Bug Something isn't working Mapping this PR changes the map Merge Conficts This PR currently has ongoing merge clonflicts Opinion This issue is based on the opinions of the author and therefore subjective in nature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants