Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Password Protection (whole app and note deletion) #21

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

WillBBHM
Copy link
Contributor

I have made the modifications for this second pull request as requested.

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

This is the link of the feature request :
#17

Description of the changes and new features

  • Added Password protect the whole aplication
  • Added Password of the app protect notes deletion
  • Added a new settings section to the settings menu, with a checkbox to enable or disable application password protection.
    (Request user to create a password)

Screenshots

  • New Settings "password" added in settings menu:
    Capture d'écran 2024-02-17 173145
  • App protection at start:
    Capture d'écran 2024-02-17 173248
  • Notes deletion protection (after confirmation delete):
    Capture d'écran 2024-02-16 223736

Acknowledgement

@Aga-C
Copy link
Member

Aga-C commented Feb 17, 2024

Now app blocking works like in other apps, thanks!

There are few more things to do:

  1. Deletion protection should be a separate option. Check other apps how it works there (Gallery or File Manager). When you'll add this option, please add a new string for it: Password protect note deletion, don't reuse the existing one.
  2. Please move Security section in Settings to be between Saving and Migration.

@WillBBHM
Copy link
Contributor Author

I've just finished making the small changes requested.

@Aga-C
Copy link
Member

Aga-C commented Feb 17, 2024

I've tested and it works fine. Please now wait for final review from Naveen.

@WillBBHM
Copy link
Contributor Author

Okay, that's great! I hope for a positive response!!

@onegladius
Copy link
Contributor

Thank you for your work!

@WillBBHM
Copy link
Contributor Author

Thank you very much, now all that’s left is to wait for Naveen to merge my contribution into the main project!!

@theKaido
Copy link

theKaido commented Mar 9, 2024

Hello, @naveensingh can we get an estimate of when this pull request will be validated? We need the validation to receive a rating. Thanks you

@naveensingh
Copy link
Member

Sorry I can't provide an ETA, it'll reviewed after I'm done updating some other apps and after the Clock app is released. I'll try to get here by the weekend.

@theKaido
Copy link

theKaido commented Mar 9, 2024

thank you for your answer

@naveensingh
Copy link
Member

naveensingh commented Mar 25, 2024

Looks good to me! Sorry, it took me this long to get here.

@naveensingh naveensingh merged commit 7510d6e into FossifyOrg:master Mar 25, 2024
@theKaido
Copy link

theKaido commented Mar 27, 2024

Thank you , Don't Worry about that ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants