Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework color customization and setup thank you #62

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

naveensingh
Copy link
Member

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Removed Auto light/dark theme in favor of system theme. System theme is replaced by Auto theme on older versions.
  • Implemented global theming as a toggle (depends on the Thank You app). This is similar to the shared theming that was available in Simple apps.
  • Setup showing checkmarks on switches for accessibility (depends on the Thank You app)
  • Cleaned up code.

Acknowledgement

### Major changes:

- Removed `Auto` theme in favor of system. `System` theme is replaced by `Auto` theme on older versions.
- Setup showing checkmarks on switches for accessibility (depends on the Thank You app)
- Implemented global theming as a toggle (depends on the Thank You app).
- Cleaned up code.
@naveensingh naveensingh merged commit 9da54b9 into master Sep 20, 2024
1 check passed
@naveensingh naveensingh deleted the global_theming branch September 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant