Fix FossifyOrg/Phone#28 (Missing contacts)

[czarnyckm]

Fix FossifyOrg/Phone#28 (Missing contacts)
According to doc ContentResolver.getIsSyncable returns value >0 if it is syncable, 0 if not, and <0 if the state isn't known yet.
see also
FossifyOrg/Phone#28 (comment)

What is it?

• [x ] Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

Before/After Screenshots/Screen Record

• Before:
• After:

Fixes the following issue(s)

Fixes FossifyOrg/Phone#28

Relies on the following changes

Acknowledgement

• [ x] I read the contribution guidelines.

[Aga-C]

Fixes FossifyOrg/Phone#28 and fixes FossifyOrg/Contacts#83.

[Honk2]

imho this is an important fix, because the app it not usable without.
When will it be merged? What is the reason that it is not merged yet?
Is there anything that needs to be done? I did not find anything about the procedures in the repo.

[Kasi07]

I agree. Is testing needed for this to be merged? In that case I would be open to test if someone could provide the apk.

[naveensingh]

Unfortunately I haven't had the time to work on this and some other important issues in Fossify (got super busy recently with some personal but unexpected matters). Hopefully I'll have some time for work after the weekend.

[Groctel]

The correct check should be ContentResolver.getIsSyncable(it, AUTHORITY) > 0 given the meaning of the function's retcodes: https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/services/core/java/com/android/server/content/SyncStorageEngine.java;l=260-289

[czarnyckm]

I fix the check ContentResolver.getIsSyncable(it, AUTHORITY) > 0

[jrd]

@naveensingh can you review and merge it please? I cannot use the app for months…

[naveensingh]

I'm aware that this is an important issue for many but I'm currently stuck in a hospital. I'll try to release an update as soon as I have some free time.

[jrd]

Ok I understand, thank you for the quick answer.

[Groctel]

@naveensingh Your wellbeing always comes first. Take all the time you need, but still get better soon ❤️❤️❤️

[naveensingh]

Apparently, getIsSyncable() returns 0 i.e. NOT_SYNCABLE when Google Play Services is disabled.

[cpontvieux-systra]

That would explain the loosy doc (and variable name). It has meaning only if you have the Google Play Service running.